Improve workload search help text to clarify version searching capability #50982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Improve workload help for workload set searching
Improve workload search help text to clarify version searching capability
Sep 24, 2025
Copilot finished work on behalf of
marcpopMSFT
September 24, 2025 17:05
…ities Co-authored-by: marcpopMSFT <[email protected]>
marcpopMSFT
force-pushed
the
copilot/fix-c24951fb-7009-4f6e-b24d-036b6633c88c
branch
from
db308c0 to
8b63493
Compare
|
Text is updated for the help description. It still lists <SEARCH_STRING> in the help but I think that's a S.CL issue and probably ok. |
marcpopMSFT
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Pull Request Overview
Updates the workload search command description to clarify that users can search for both workloads and workload versions, improving discoverability of the dotnet workload search version functionality.
Key changes:
- Enhanced help text from "Search for available workloads." to "Search for available workloads or workload versions."
- Updated all localization files with proper review states to maintain translation consistency
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Updated main resource string for workload search command description |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.*.xlf | Updated localization files with new source text and needs-review-translation state |
baronfel
approved these changes
Oct 1, 2025
|
@copilot can you fix the test: |
|
@copilot another test failure: |
Co-authored-by: marcpopMSFT <[email protected]>
... This was already fixed in commit 5174432. Both the pwsh and zsh snapshot files were updated with the new help text "Search for available workloads or workload versions." The tests pass locally. The error you're seeing may be from a CI run before the fix was pushed. |
Copilot finished work on behalf of
marcpopMSFT
October 2, 2025 23:33
marcpopMSFT
deleted the
copilot/fix-c24951fb-7009-4f6e-b24d-036b6633c88c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to improve workload help for workload set searching
Issue: The top-level
dotnet workload -hhelp output doesn't make it clear that thesearchcommand can also search for workload versions/sets using theversionsubcommand.Completed work:
dotnet workload search versionfunctionality exists but is not mentioned in the top-level help/src/Cli/dotnet/Commands/CliCommandStrings.resxline 2531Changes made:
WorkloadSearchCommandDescriptionfrom "Search for available workloads." to "Search for available workloads or workload versions."needs-review-translationstate as expectedtest/dotnet.Tests/CompletionTests/snapshots/zsh/DotnetCliSnapshotTests.VerifyCompletions.verified.zshtest/dotnet.Tests/CompletionTests/snapshots/pwsh/DotnetCliSnapshotTests.VerifyCompletions.verified.ps1Verification:
dotnet workload -hnow shows: "search <SEARCH_STRING> Search for available workloads or workload versions."dotnet workload search -hshows the updated descriptiondotnet workload search version -hstill works correctlyFixes #50981
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.